Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Providing an instance of InMemoryCacheHandler doesn't work - instanceof CacheHandler is false  #1736

Copy link
Copy link
Open
@perholmang

Description

@perholmang
Issue body actions

When creating an instance of InMemoryCacheHandler and providing it to ISRHandler, the instance isn't being used but instead the default handler. It seems the problem is that it checks that the provided handler is an instance of CacheHandler which is false.

const cacheHandler = new InMemoryCacheHandler();
  console.log(cacheHandler instanceof CacheHandler); // this returns false

  const isr = new ISRHandler({
    indexHtml,
    invalidateSecretToken: 'helloworld', // replace with env secret key ex. process.env.REVALIDATE_SECRET_TOKEN
    enableLogging: true,
    cache: cacheHandler,
    serverDistFolder,
    browserDistFolder,
    bootstrap,
    commonEngine,
  });

Environment

"@rx-angular/isr": "^17.1.0"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.