clear the accessible devices tab when retrieving accessible devices disabled #11913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request implements functionality to clear the accessible devices tab when the error "Retrieving accessible devices is disabled." is encountered during a pull.
- Adds a call to _tryHandlePullError immediately after performing the pull
- Introduces a new method _tryHandlePullError that clears users, peers, and deviceGroups based on the error message
Comments suppressed due to low confidence (1)
flutter/lib/models/group_model.dart:367
- Consider using a structured error object or error code for error handling rather than relying on substring matching of error messages. This can improve reliability and clarity in determining when to clear the device lists.
String errorMessage = groupLoadError.value;
11f1248 to
4bbab54
Compare
…s disabled Signed-off-by: 21pages <sunboeasy@gmail.com>
4bbab54 to
e2ed4d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message is "Retrieving accessible devices is disabled."
before:
after:
