Weighted var#55
Weighted var#55LukeMathWalker merged 8 commits intorust-ndarray:masterrust-ndarray/ndarray-stats:masterfrom
Conversation
|
Thanks for working on this! |
No worries, not a big deal.
I have yet to find a use for
Well, that's exactly what we are doing 😁
To notice a difference you need to evaluate it on arrays with a lot of elements, even better if they lead to somewhat badly conditioned operations. The first issue there is the summing algorithm we are using, the naive one. Using pairwise summation would greatly improve numerical stability, but there are pros and cons at the moment, considering that we do not have specialization. Overall it looks good to me 👍 |
|
I added a benchmark (azip! was slower) but I'm not sure about using mul_add because criterion tells me that it's slower. It's more precise though (from 1e-10 to 1e-11). I'll add it if you want. |
|
That's interesting! Could you post |
|
I replace with
|


Here's the var/std version.
git mv. Ctrl-fweighted_varandweighted_stdto know what I actually changed.A::from_usize(0)fails? Anunwrapwould be safe, no?