Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Tests do not pass with --profile release #103

Copy link
Copy link
@LecrisUT

Description

@LecrisUT
Issue body actions

While packaging this project for Fedora, we encountered test failures:

test entropy::tests::test_kl ... ok
test entropy::tests::test_kl_with_noisy_negative_qs - should panic ... FAILED
test histogram::bins::bins_tests::get_panics_for_out_of_bounds_indexes - should panic ... ok
test entropy::tests::test_cross_entropy_with_noisy_negative_qs - should panic ... FAILED
test histogram::strategies::auto_tests::empty_arrays_are_bad ... ok

#[test]
#[should_panic]
fn test_cross_entropy_with_noisy_negative_qs() {
let p = array![n64(1.)];
let q = array![n64(-1.)];
let _ = p.cross_entropy(&q);
}
#[test]
#[should_panic]
fn test_kl_with_noisy_negative_qs() {
let p = array![n64(1.)];
let q = array![n64(-1.)];
let _ = p.kl_divergence(&q);
}

I have tried locally with --profile dev/release and confirmed that the failure of "should_panic" is specific to release. We believe the issue is that f64::log does not (always?) panic for negative numbers, instead it would just return NaN.

Edit: we discussed it a bit more and it is more likely because of noisy_float implementation

For each floating point number that is created, a debug_assert! invocation is used to check if it is valid or not.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.