implement partialord min/max#514
Closed
sebasv wants to merge 5 commits intorust-ndarray:masterrust-ndarray/ndarray:masterfrom
Closed
implement partialord min/max#514sebasv wants to merge 5 commits intorust-ndarray:masterrust-ndarray/ndarray:masterfrom
sebasv wants to merge 5 commits intorust-ndarray:masterrust-ndarray/ndarray:masterfrom
Conversation
Contributor
Author
|
Forgot to mention! This depends on #507 . Travis should pass when that PR makes it into master. |
bluss
reviewed
Oct 27, 2018
Member
|
Needs discussion what to do with the overlap with ndarray-stats https://docs.rs/ndarray-stats/ If this is in ndarray, I'd prefer something that's more geared towards the needs of floating point elements |
|
Hey @bluss what do you mean, when you say that it should be more geared toward floating point elements? |
Contributor
Author
|
Closing as I don't see myself picking this up anytime soon. Feel free to take over |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #512 , but for
PartialOrd. Unorderable cases such asf64::NANresult in an early return ofNone. Ideally there is also a variant that ignores unorderable cases, something likescalar_max_ignore_unorderable(), but with a more sensible name.