Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add flatten, flatten_with_order and into_flat to arrays#1397

Merged
bluss merged 1 commit intorust-ndarray:masterrust-ndarray/ndarray:masterfrom
barakugav:flattenbarakugav/ndarray:flattenCopy head branch name to clipboard
Aug 2, 2024
Merged

Add flatten, flatten_with_order and into_flat to arrays#1397
bluss merged 1 commit intorust-ndarray:masterrust-ndarray/ndarray:masterfrom
barakugav:flattenbarakugav/ndarray:flattenCopy head branch name to clipboard

Conversation

@barakugav
Copy link
Contributor

No description provided.

src/impl_methods.rs Outdated Show resolved Hide resolved
@barakugav barakugav force-pushed the flatten branch 2 times, most recently from 342f1f3 to 692fae5 Compare July 11, 2024 09:41
src/impl_methods.rs Show resolved Hide resolved
src/impl_methods.rs Outdated Show resolved Hide resolved
@bluss
Copy link
Member

bluss commented Jul 21, 2024

Maintainer pushed to fix to always use into_shape_clone (it only clones when necessary)

@bluss
Copy link
Member

bluss commented Jul 21, 2024

clippy lints we'll fix in another PR

@bluss
Copy link
Member

bluss commented Jul 28, 2024

Can now be rebased on master because clippy errors are fixed there.

@bluss bluss added this to the 0.16.0 milestone Aug 1, 2024
@bluss bluss changed the title Adds 'flatten()' method to array Add flatten, flatten_with_order and into_flat to arrays Aug 2, 2024
@bluss bluss enabled auto-merge August 2, 2024 19:23
@bluss bluss added this pull request to the merge queue Aug 2, 2024
Merged via the queue into rust-ndarray:master with commit 91ecb92 Aug 2, 2024
@barakugav barakugav deleted the flatten branch August 6, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.