Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update ci - run cross tests only on master#1366

Merged
bluss merged 2 commits intomasterrust-ndarray/ndarray:masterfrom
cirust-ndarray/ndarray:ciCopy head branch name to clipboard
Mar 9, 2024
Merged

Update ci - run cross tests only on master#1366
bluss merged 2 commits intomasterrust-ndarray/ndarray:masterfrom
cirust-ndarray/ndarray:ciCopy head branch name to clipboard

Conversation

@bluss
Copy link
Member

@bluss bluss commented Mar 9, 2024

Cross actions are very slow. They give us coverage on 32-bit and big endian, but are rather less important. Also update the checkout action because the old one has deprecation warnings.

@adamreichold
Copy link
Collaborator

I think, ideally we'd use merge queues to run the cross asynchronously but before merging into the main branch. The PR workflow it self could then be simplify down even further, e.g. just tests on stable and Clippy.

@bluss
Copy link
Member Author

bluss commented Mar 9, 2024

sounds good, so like bors or whatever the new version would be

@bluss bluss merged commit 436b4c1 into master Mar 9, 2024
@bluss bluss deleted the ci branch March 9, 2024 13:49
@adamreichold
Copy link
Collaborator

sounds good, so like bors or whatever the new version would be

Yes, but integrated into GitHub. You'll need to enable it in the project settings and then:

  • We don't run CI on the main branch at all any more because all commits are tested before being put there.
  • Which tests are run is not differentiated by branch name but by event, either pull requests or merge queues.
  • PR run should small and fast for quick feedback on proposed changes.
  • Pre-merge checks should be complete so that the main branch is always is a known good state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.