Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Code formatting #1292

Copy link
Copy link
@nilgoyette

Description

@nilgoyette
Issue body actions

The code in this repository doesn't seem to be formatted by rustfmt, which can lead to useless discussions and back and forth in the PRs. The advantages of a standard code formatter are already well known. As a programmer myself, I don't see any reason not to use it, but I'm might have a blind spot.

A comment from @adamreichold

The two options I see personally is to make a single mass change to enforce Rustfmt usage throughout the code base including in the CI. Or to limit this to files touch in any PR. (I think it should be possible to enforce this using GitHub Actions' path rules.)

((Personally, I would be very much in favour of Rustfmt usage throughout. I don't care much about the formatting itself as long as it is uniform and automatic. But that just is not the approach taken by this code base so far which I think could override this perspective.))

@adamreichold I understand that doing a PR with a full code formatting commit would

  • make "git blame" useless
  • create conflicts in all PR

Would the use of "GitHub Actions' path rules" solve those 2 problems?

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.