Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Document Ambig vs Unambig Type/Consts #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2025
Merged

Document Ambig vs Unambig Type/Consts #2474

merged 4 commits into from
Jun 18, 2025

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Jun 17, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2025

Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using r? rustc-dev-guide or r? <username>.

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Jun 17, 2025
@BoxyUwU BoxyUwU requested a review from lcnr June 17, 2025 14:57
@BoxyUwU BoxyUwU force-pushed the ambig_unambig_ty_consts branch from 3972cf8 to c963b4a Compare June 17, 2025 17:09
nnethercote
nnethercote reviewed Jun 17, 2025
View reviewed changes
src/hir/ambig-unambig-ty-and-consts.md Outdated Show resolved Hide resolved
nnethercote
nnethercote reviewed Jun 17, 2025
View reviewed changes
src/hir/ambig-unambig-ty-and-consts.md Outdated Show resolved Hide resolved
nnethercote
nnethercote reviewed Jun 17, 2025
View reviewed changes
src/hir/ambig-unambig-ty-and-consts.md Outdated Show resolved Hide resolved
lcnr
lcnr reviewed Jun 18, 2025
View reviewed changes
src/hir/ambig-unambig-ty-and-consts.md Outdated Show resolved Hide resolved
lcnr
lcnr reviewed Jun 18, 2025
View reviewed changes
src/hir/ambig-unambig-ty-and-consts.md Outdated Show resolved Hide resolved
lcnr
lcnr reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor

@lcnr lcnr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after dealing with the nits

@BoxyUwU BoxyUwU force-pushed the ambig_unambig_ty_consts branch from 639fa85 to 9d7ba85 Compare June 18, 2025 14:29
@BoxyUwU BoxyUwU merged commit e0a3918 into rust-lang:master Jun 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote left review comments

@lcnr lcnr lcnr left review comments

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BoxyUwU @rustbot @nnethercote @lcnr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.