Improve 'async' contextual keyword highlighting #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
According to the docs Until edition 2018 is default in Rust and Cargo, we should default to highlighting like it's edition 2015, and in the future, auto-detect the currently configured edition in Cargo.toml and perform syntax highlighting accordingly. For now, a bridging solution that handles the contextual use of Thanks! |
alok
added a commit
to alok/rust.vim
that referenced
this pull request
Feb 5, 2019
* remotes/original/master: (423 commits) Use 'setfiletype' to avoid load 'ftplugin/rust.vim' twice (rust-lang#301) avoid setting `isfname` allow 'pub use' Set `include` and improve `includeexpr` Revert "BufWritePre should be <buffer>" Recognize edition2015 and edition2018 doc test specifiers Revert "RustTest: specify module name to run exact one test case" RustTest: specify module name to run exact one test case RustTest: use :terminal for running tests ftplugin/rust.vim: Better to narrow augroup scope rustfmt: remove incorrect version check rustfmt: simplify regex tests Improve 'async' contextual keyword highlighting (rust-lang#290) RustFmt: fix non-existant temp file Add new keywords (rust-lang#282) Add SyntasticInfo if exists to the output of RustInfo Check that Syntastic is new enough Update rust.txt Add `cargo#guessrun` function & `Cgrun` command Fix RunRustfmt() for Vim 7.x ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncis a contextual keyword. For example, when it is used in context of scope resolution (::),asynccan be used as module name. In the case, theasyncname should be highlighted as normal identifier, not a keyword.This patch restricts highlighting
asyncas keyword only when space or newline is following. So nowasyncin module resolution such asfoo::async::Xis highlighted as normal module name.Here is a screenshot: