Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

associated_consts: check trait obligations and regionck for associated consts #42324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2017
Merged

associated_consts: check trait obligations and regionck for associated consts #42324

merged 1 commit into from
Jun 1, 2017

Conversation

seanmonstar
Copy link
Contributor

Closes #41323

r? @nikomatsakis

@arielb1 arielb1 added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label May 31, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 31, 2017

This needs a crater run - people might have been trying to sneak things.

@seanmonstar
Copy link
Contributor Author

A crater run? It's an unstable feature, and this fixes a soundness hole, as described in #41323.

@nikomatsakis
Copy link
Contributor

I don't think that a crater run is needed for an unstable feature, but it'd be a kindness.

@nikomatsakis
Copy link
Contributor

I'm going to kick off a crater run, but I'll r+ in the meantime.

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented May 31, 2017

📌 Commit 62989c1 has been approved by nikomatsakis

@nikomatsakis nikomatsakis removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label May 31, 2017
@arielb1
Copy link
Contributor

arielb1 commented May 31, 2017

@seanmonstar

Missed that this is in an unstable feature.

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 1, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 1, 2017
@frewsxcv
Rollup merge of rust-lang#42324 - seanmonstar:41323-compare_const_imp…
bf4e146 
…l, r=nikomatsakis

associated_consts: check trait obligations and regionck for associated consts

Closes rust-lang#41323

r? @nikomatsakis
@frewsxcv frewsxcv mentioned this pull request Jun 1, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Jun 1, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 1, 2017
@frewsxcv
Rollup merge of rust-lang#42324 - seanmonstar:41323-compare_const_imp…
9d68a23 
…l, r=nikomatsakis

associated_consts: check trait obligations and regionck for associated consts

Closes rust-lang#41323

r? @nikomatsakis
@frewsxcv frewsxcv mentioned this pull request Jun 1, 2017
Merged
bors added a commit that referenced this pull request Jun 1, 2017
@bors
Auto merge of #42348 - frewsxcv:rollup, r=frewsxcv
38efb2e 
Rollup of 9 pull requests

- Successful merges: #42136, #42275, #42286, #42297, #42302, #42306, #42314, #42324, #42347
- Failed merges:
@bors bors merged commit 62989c1 into rust-lang:master Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakis nikomatsakis

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@seanmonstar @arielb1 @nikomatsakis @bors @aidanhs
Morty Proxy This is a proxified and sanitized view of the page, visit original site.