Implement VecDeque::extract_if #147780
Open
Implement VecDeque::extract_if #147780
+487
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <wander4096@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f120ac2 to
6f38bda
Compare
This comment has been minimized.
This comment has been minimized.
6f38bda to
1d182aa
Compare
This comment has been minimized.
This comment has been minimized.
1d182aa to
238229b
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
238229b to
9cba3ed
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
|
This is now ready for review. I'm trying to port some tests from LinkedList's extract_if cases. |
This comment has been minimized.
This comment has been minimized.
c42dc3b to
ff878de
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: tison <wander4096@gmail.com>
ff878de to
2915a63
Compare
| // We use copy for move, and never touch this element again. | ||
| unsafe { | ||
| let hole_slot = self.vec.ptr().add(idx - self.del); | ||
| ptr::copy_nonoverlapping(cur, hole_slot, 1); |
There was a problem hiding this comment.
Should this instead be wrap_copy?
There was a problem hiding this comment.
Yes correct. Try fix in a7d0a43.
There was a problem hiding this comment.
CI looks happy. I'm not sure how to ensure the manner, i.e., constructing a VecDeque that wrap the underlying vec.
Signed-off-by: tison <wander4096@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refers to #147750.