additional edge cases tests for path.rs 🧪
#141105
Conversation
This comment has been minimized.
This comment has been minimized.
|
It appears that |
|
|
It looks as if |
|
Yes, please fix the tests to only use functions from OsStr and OsString OR cfg the tests. |
This comment has been minimized.
This comment has been minimized.
| // Test: Reserved device names (Windows) | ||
| // This test ensures that reserved device names like "CON", "PRN", etc., are handled as normal paths on non-Windows platforms, | ||
| // and as special cases on Windows (if applicable). |
There was a problem hiding this comment.
This comment doesn't seem to describe the test.
| // Test: Trailing dots/spaces (Windows) | ||
| // This test checks how Path handles trailing dots or spaces, which are special on Windows. | ||
| // On Unix, these should be treated as normal characters. |
There was a problem hiding this comment.
Path mostly works the same across platforms (separator differences and roots/prefixes not withstanding). If there's a difference then you should have tests for both Windows and non-Windows that shows the difference.
| // Test: Only extension (e.g., ".gitignore") | ||
| // This test verifies that files with only an extension and no base name are handled correctly. | ||
| // It checks that the extension is recognized and the file stem is None or empty as appropriate. |
There was a problem hiding this comment.
Do we really not have a test for this anywhere else?
There was a problem hiding this comment.
Actually I think you are right and this is tested already here:
rust/library/std/tests/path.rs
Lines 1127 to 1130 in 2c12b4a
| // Test: Long components | ||
| // This test checks that Path can handle very long path components without truncation or error. | ||
| // It ensures that the length of the component is preserved. |
There was a problem hiding this comment.
I'm not sure why this would be useful for us specifically? We don't usually check that slice wrappers work on the whole slice.
There was a problem hiding this comment.
I'll remove this test and a few others that we think aren't the most useful perhaps
This pull request adds a few new edge case tests to the
std::pathmodule. The new tests cover scenarios such as paths with only separators, non-ASCII and Unicode characters, embedded null bytes, etc. Each new test is documented with some helpful in-line comments as well.