Remove redundant tainting. We already taint the first time we set the…

… value
rust-lang · bors · Dec 19, 2024 · Dec 17, 2024 · Dec 17, 2024 · Dec 17, 2024
commit 45920d2f52e7d3025466b6207f78189d0c347d82
diff --git a/compiler/rustc_hir_typeck/src/fn_ctxt/_impl.rs b/compiler/rustc_hir_typeck/src/fn_ctxt/_impl.rs
@@ -147,13 +147,8 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
        let mut typeck = self.typeck_results.borrow_mut();
        let mut node_ty = typeck.node_types_mut();
        if let Some(ty) = node_ty.get(id)
-            && let Err(e) = ty.error_reported()
+            && ty.references_error()
        {
-            // Do not overwrite nodes that were already marked as `{type error}`. This allows us to
-            // silence unnecessary errors from obligations that were set earlier than a type error
-            // was produced, but that is overwritten by later analysis. This happens in particular
-            // for `Sized` obligations introduced in gather_locals. (#117846)
-            self.set_tainted_by_errors(e);
            return;
        }