Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

sfackler
Copy link
Member

I switched the assert! calls in RefCell over to debug_assert!.
There are probably other instances that should be converted as well, but
I couldn't think of any off the top of my head.

RFC: 0015-assert

@alexcrichton
Copy link
Member

If you grep for 12049 you'll find a few other debug assertions which should migrate to using debug_assert!

@sfackler
Copy link
Member Author

Updated

@huonw
Copy link
Contributor

huonw commented Apr 27, 2014

Are we testing things with both --cfg ndebug and without it on the bots?

@sfackler
Copy link
Member Author

If not, we should just turn on --enable-debug on the nopt builders.

@alexcrichton
Copy link
Member

--cfg ndebug is only passed when --disable-debug is passed to the configure script, currently there are no builders that do this.

sfackler added 2 commits May 1, 2014 19:07
I also switched some `assert!` calls over to `debug_assert!`.

Closes rust-lang#12049.

RFC: 0015-assert
@sfackler
Copy link
Member Author

sfackler commented May 2, 2014

This should be good to go.

cc @pcwalton

bors added a commit that referenced this pull request May 2, 2014
I switched the `assert!` calls in `RefCell` over to `debug_assert!`.
There are probably other instances that should be converted as well, but
I couldn't think of any off the top of my head.

RFC: 0015-assert
@bors bors closed this May 2, 2014
@bors bors merged commit ca84d79 into rust-lang:master May 2, 2014
@sfackler sfackler deleted the debug-assert branch May 15, 2014 05:02
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2023
feat: show only missing variant suggestion for enums in patterns completion and bump them in list too

Fixes rust-lang#12438

### Points to help in review:

- This PR can be reviewed commit wise, first commit is about bumping enum variant completions up in the list of completions and second commit is about only showing enum variants which are not complete
- I am calculating missing variants in analysis.rs by firstly locating the enum and then comparing each of it's variant's name and checking if arm string already contains that name, this is kinda hacky but I didn't want to implement complete missing_arms assist here as that would have been too bulky to run on each completion cycle ( if we can improve this somehow would appreciate some inputs on it )

### Output:

https://user-images.githubusercontent.com/49019259/208245540-57d7321b-b275-477e-bef0-b3a1ff8b7040.mov

Relevant Zulip Discussion: https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/Issue.20.2312438
flip1995 pushed a commit to flip1995/rust that referenced this pull request Dec 15, 2024
This addresses rust-lang#13099 for the manual_split_once test, using the
str_splitn lint.

changelog: [str_splitn]: Updated str_splitn to use multipart_suggestions
where appropriate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.