Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c089b1f

Browse filesBrowse files
chenyukangchenyukang
committed
add testcase for long expression
1 parent 41a7534 commit c089b1f
Copy full SHA for c089b1f

File tree

Expand file treeCollapse file tree

4 files changed

+37
-9
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+37
-9
lines changed

‎src/etc/test-float-parse/src/lib.rs

Copy file name to clipboardExpand all lines: src/etc/test-float-parse/src/lib.rs
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,7 @@ fn launch_tests(tests: &mut [TestInfo], cfg: &Config) -> Duration {
333333
for test in tests.iter_mut() {
334334
test.progress = Some(ui::Progress::new(test, &mut all_progress_bars));
335335
ui::set_panic_hook(&all_progress_bars);
336-
(t.launch)(test, cfg);
336+
(test.launch)(test, cfg);
337337
}
338338

339339
start.elapsed()

‎tests/ui/lint/unused/closure-body-issue-136741.fixed

Copy file name to clipboardExpand all lines: tests/ui/lint/unused/closure-body-issue-136741.fixed
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
//@ run-rustfix
2+
// ignore-tidy-linelength
23
#![deny(unused_parens)]
34
#![deny(unused_braces)]
5+
6+
fn long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
7+
{}
8+
9+
fn func(f: impl FnOnce()) {
10+
f()
11+
}
12+
413
pub fn main() {
514
let _closure = |x: i32, y: i32| x * (x + (y * 2)); //~ ERROR unnecessary braces around closure body
615
let _ = || 0 == 0; //~ ERROR unnecessary parentheses around closure body
@@ -19,4 +28,9 @@ pub fn main() {
1928
_ = 0;
2029
0 == 0 //~ ERROR unnecessary parentheses around block return value
2130
};
31+
32+
// long expressions will not lint with braces
33+
func(|| {
34+
long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
35+
})
2236
}

‎tests/ui/lint/unused/closure-body-issue-136741.rs

Copy file name to clipboardExpand all lines: tests/ui/lint/unused/closure-body-issue-136741.rs
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
//@ run-rustfix
2+
// ignore-tidy-linelength
23
#![deny(unused_parens)]
34
#![deny(unused_braces)]
5+
6+
fn long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
7+
{}
8+
9+
fn func(f: impl FnOnce()) {
10+
f()
11+
}
12+
413
pub fn main() {
514
let _closure = |x: i32, y: i32| { x * (x + (y * 2)) }; //~ ERROR unnecessary braces around closure body
615
let _ = || (0 == 0); //~ ERROR unnecessary parentheses around closure body
@@ -21,4 +30,9 @@ pub fn main() {
2130
_ = 0;
2231
(0 == 0) //~ ERROR unnecessary parentheses around block return value
2332
};
33+
34+
// long expressions will not lint with braces
35+
func(|| {
36+
long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces_long_expr_that_does_not_require_braces()
37+
})
2438
}

‎tests/ui/lint/unused/closure-body-issue-136741.stderr

Copy file name to clipboardExpand all lines: tests/ui/lint/unused/closure-body-issue-136741.stderr
+8-8Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
error: unnecessary braces around closure body
2-
--> $DIR/closure-body-issue-136741.rs:5:37
2+
--> $DIR/closure-body-issue-136741.rs:14:37
33
|
44
LL | let _closure = |x: i32, y: i32| { x * (x + (y * 2)) };
55
| ^^ ^^
66
|
77
note: the lint level is defined here
8-
--> $DIR/closure-body-issue-136741.rs:3:9
8+
--> $DIR/closure-body-issue-136741.rs:4:9
99
|
1010
LL | #![deny(unused_braces)]
1111
| ^^^^^^^^^^^^^
@@ -16,13 +16,13 @@ LL + let _closure = |x: i32, y: i32| x * (x + (y * 2));
1616
|
1717

1818
error: unnecessary parentheses around closure body
19-
--> $DIR/closure-body-issue-136741.rs:6:16
19+
--> $DIR/closure-body-issue-136741.rs:15:16
2020
|
2121
LL | let _ = || (0 == 0);
2222
| ^ ^
2323
|
2424
note: the lint level is defined here
25-
--> $DIR/closure-body-issue-136741.rs:2:9
25+
--> $DIR/closure-body-issue-136741.rs:3:9
2626
|
2727
LL | #![deny(unused_parens)]
2828
| ^^^^^^^^^^^^^
@@ -33,7 +33,7 @@ LL + let _ = || 0 == 0;
3333
|
3434

3535
error: unnecessary parentheses around closure body
36-
--> $DIR/closure-body-issue-136741.rs:7:28
36+
--> $DIR/closure-body-issue-136741.rs:16:28
3737
|
3838
LL | let _ = (0..).find(|n| (n % 2 == 0));
3939
| ^ ^
@@ -45,7 +45,7 @@ LL + let _ = (0..).find(|n| n % 2 == 0);
4545
|
4646

4747
error: unnecessary braces around closure body
48-
--> $DIR/closure-body-issue-136741.rs:8:28
48+
--> $DIR/closure-body-issue-136741.rs:17:28
4949
|
5050
LL | let _ = (0..).find(|n| {n % 2 == 0});
5151
| ^ ^
@@ -57,7 +57,7 @@ LL + let _ = (0..).find(|n| n % 2 == 0);
5757
|
5858

5959
error: unnecessary parentheses around closure body
60-
--> $DIR/closure-body-issue-136741.rs:16:28
60+
--> $DIR/closure-body-issue-136741.rs:25:28
6161
|
6262
LL | let _ = (0..).find(|n| (
6363
| _____________________________^
@@ -76,7 +76,7 @@ LL + let _ = (0..).find(|n| n % 2 == 0);
7676
|
7777

7878
error: unnecessary parentheses around block return value
79-
--> $DIR/closure-body-issue-136741.rs:22:9
79+
--> $DIR/closure-body-issue-136741.rs:31:9
8080
|
8181
LL | (0 == 0)
8282
| ^ ^

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.