Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

ipetkov
Copy link
Contributor

@ipetkov ipetkov commented Jun 24, 2015

@ipetkov
Copy link
Contributor Author

ipetkov commented Jun 24, 2015

cc @alexcrichton @aturon

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the RFC. label Jun 24, 2015
@alexcrichton alexcrichton self-assigned this Jun 30, 2015
@sfackler
Copy link
Member

sfackler commented Jul 1, 2015

I like the idea of this functionality, but I'd go with Into<RawFd> etc instead of defining new traits. The common convention is to both implement Into<Foo> and add an into_foo() method to a type, since Into is useful in a generic context but can be a bit of a pain to use if you have a concrete TcpStream or whatever that has multiple Into impls.

@alexcrichton
Copy link
Member

Unfortunately using Into<RawFd> means that when you convert an object to a file descriptor there's no platform-specific opt-in, you instead just call let a: i32 = file.into() and it becomes a portability hazard. In having separate traits you acknowledge the platform-specific-ness via use std::os::unix::....

@sfackler
Copy link
Member

sfackler commented Jul 1, 2015

Ah, yeah, that makes sense. I'm on board with IntoRaw{Fd,Handle,Socket} then.

@l0kod
Copy link

l0kod commented Jul 6, 2015

👍

@alexcrichton
Copy link
Member

This RFC is now entering its week-long final comment period.

@alexcrichton alexcrichton added the final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. label Jul 8, 2015
@alexcrichton
Copy link
Member

The consensus of the libs team this week is to merge this RFC, so I'm going to do so. Thanks again for the RFC @ipetkov!

Tracking issue

@alexcrichton alexcrichton merged commit 605af89 into rust-lang:master Jul 16, 2015
@ipetkov ipetkov deleted the into-raw-trait branch July 16, 2015 08:19
@aturon aturon mentioned this pull request Jul 16, 2015
@Centril Centril added the A-net Proposals relating to networking. label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-net Proposals relating to networking. final-comment-period Will be merged/postponed/closed in ~10 calendar days unless new substational objections are raised. T-libs-api Relevant to the library API team, which will review and decide on the RFC.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.