Drop support for building 32-bit Apple docs #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust's RFC 2837 demoted the i686-apple-darwin target to Tier 3, so that target will not be downloadable anymore through rustup starting from Rust 1.42.0. The change will also land on nightly soon, and that will prevent docs.rs from updating the rustwide toolchain. This removes i686-apple-darwin from the list of targets we build.
4 tasks
jyn514
reviewed
Dec 30, 2019
|
We can merge this. Are you fine with the current state of the code @jyn514? |
|
I have a nagging feeling I missed something ... but the code itself looks fine, I'm ok with merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust's RFC 2837 demoted the
i686-apple-darwintarget to Tier 3, so that target will not be downloadable anymore through rustup starting from Rust 1.42.0. The change will also land on nightly soon, and that will prevent docs.rs from updating the rustwide toolchain.This PR removes
i686-apple-darwinfrom the list of targets we build, and adds code to remove it automatically from existing rustwide workspaces.This is ready for review, but we should hold off deploying it until we announce the demotion on the blog.