Adds paragraph about Edict 0.2 #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17cupsofcoffee
requested changes
Sep 11, 2022
There was a problem hiding this comment.
Sorry for the delay in reviewing, think everyone has been a bit busy this month.
This section seems a bit long/overly technical to me - we generally try to keep them below 1000 rendered characters, give or take. I appreciate some level of detail is needed to get across what makes Edict different from the (many 😅) other Rust ECS libraries, but if possible it'd be good to make this a bit closer in length to the other sections.
|
Not many enough I guess, since new ones are popped like sprouts in the spring. |
|
I've cut it to 1212 rendered chars. Let me know if that's suffice or I need to cut some more. |
|
Does this edit look ok? I'm trying to improve the section for clarity.
|
|
Looks good to me |
AngelOnFira
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1134
Adds paragraph about upcoming update Edict 0.2