Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

<hr/> tag looks weird with margin: 0 #11

Copy link
Copy link
Closed
@ozkriff

Description

@ozkriff
Issue body actions

Minima's _base.scss file resets the margin of the <hr> tag to zero:

body, h1, h2, h3, h4, h5, h6,
p, blockquote, pre, hr,
dl, dd, ol, ul, figure {
margin: 0;

And it results in that Markdown's horizontal line ------ sticks to the next line uncomfortably close:

image

With this brute-force patch:

$ git diff _sass/
diff --git a/_sass/minima/_base.scss b/_sass/minima/_base.scss
index db7d5a1..cac4ba7 100644
--- a/_sass/minima/_base.scss
+++ b/_sass/minima/_base.scss
@@ -37,6 +37,7 @@ body {
 h1, h2, h3, h4, h5, h6,
 p, blockquote, pre,
 ul, ol, dl, figure,
+hr,
 %vertical-rhythm {
   margin-bottom: $spacing-unit / 2;
 }

it looks much better to me:

image

But I'm note sure if that's the correct way of doing it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.