Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@mguinness
Copy link

I had to tweak the rule class to change Inputs field from IEnumerable to IList for compatibility w/ IConfiguration. I updated tests and also added section to README for details in use.

@jamescurran
Copy link
Contributor

I can't see how I'd implement the Inputs property without used a List<> or an array as the backing store, so this shouldn't be a problem.

@mguinness
Copy link
Author

mguinness commented Jan 23, 2021

If I need the opposite of IsInInput is there a way to do that other than creating a new expression like below?

case "NotInInput":
    return Expression.Not(Expression.Call(Expression.Constant(rule.Inputs.ToList()),
                            _miListContains.Value,
                            propExpression));

Or maybe add a new boolean field called Negate on Rule class that would invoke Expression.Not if true?

@mguinness
Copy link
Author

@jamescurran Do you think that this can be merged, do you need anything else from me?

@mguinness
Copy link
Author

@jamescurran Any update on if this change to support the JSON configuration provider can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.