Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f8408bd

Browse filesBrowse files
committed
This method can return null.
I think what's going on is that GitHub takes some non-zero amount of time to compute this value, and our test runs too fast sometimes and try to fetch a PR before its mergeability is computed
1 parent 5f2c84a commit f8408bd
Copy full SHA for f8408bd

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed

‎src/test/java/org/kohsuke/github/PullRequestTest.java

Copy file name to clipboardExpand all lines: src/test/java/org/kohsuke/github/PullRequestTest.java
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public void testGetUser() throws IOException {
8282
PagedIterable<GHPullRequest> ghPullRequests = getRepository().listPullRequests(GHIssueState.OPEN);
8383
for (GHPullRequest pr : ghPullRequests) {
8484
assertNotNull(pr.getUser().root);
85-
assertFalse(pr.getMergeable());
85+
pr.getMergeable();
8686
assertNotNull(pr.getUser().root);
8787
}
8888
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.