Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9afad71

Browse filesBrowse files
committed
Newly created user object resets root to null.
Fixes issue hub4j#111. Test case from KostyaSha
1 parent 7bbe0f7 commit 9afad71
Copy full SHA for 9afad71

File tree

Expand file treeCollapse file tree

3 files changed

+23
-12
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+23
-12
lines changed

‎src/main/java/org/kohsuke/github/GHPullRequest.java

Copy file name to clipboardExpand all lines: src/main/java/org/kohsuke/github/GHPullRequest.java
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ public int getChangedFiles() throws IOException {
194194
private void populate() throws IOException {
195195
if (merged_by!=null) return; // already populated
196196

197-
root.retrieve().to(url, this);
197+
root.retrieve().to(url, this).wrapUp(owner);
198198
}
199199

200200
/**

‎src/test/java/Foo.java

Copy file name to clipboard
+6-11Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,17 @@
1-
import org.kohsuke.github.GHIssue;
2-
import org.kohsuke.github.GHOrganization;
3-
import org.kohsuke.github.GHTeam;
1+
import org.kohsuke.github.GHRepository;
42
import org.kohsuke.github.GitHub;
5-
import org.kohsuke.github.PagedIterable;
6-
import org.kohsuke.github.PagedSearchIterable;
73

8-
import java.util.Arrays;
9-
import java.util.Map;
4+
import java.util.Collection;
105

116
/**
127
* @author Kohsuke Kawaguchi
138
*/
149
public class Foo {
1510
public static void main(String[] args) throws Exception {
16-
PagedSearchIterable<GHIssue> reviewbybees = GitHub.connect().searchIssues().mentions("reviewbybees").isOpen().list();
17-
for (GHIssue r : reviewbybees) {
18-
System.out.println(r.getTitle());
11+
Collection<GHRepository> lst = GitHub.connect().getUser("kohsuke").getRepositories().values();
12+
for (GHRepository r : lst) {
13+
System.out.println(r.getName());
1914
}
20-
System.out.println("total="+reviewbybees.getTotalCount());
15+
System.out.println(lst.size());
2116
}
2217
}

‎src/test/java/org/kohsuke/github/PullRequestTest.java

Copy file name to clipboardExpand all lines: src/test/java/org/kohsuke/github/PullRequestTest.java
+16Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,22 @@ public void setAssignee() throws Exception {
3838
assertEquals(user, getRepository().getPullRequest(p.getNumber()).getAssignee());
3939
}
4040

41+
@Test
42+
public void testGetUser() throws IOException {
43+
GHPullRequest p = getRepository().createPullRequest(rnd.next(), "stable", "master", "## test");
44+
GHPullRequest prSingle = getRepository().getPullRequest(p.getNumber());
45+
assertNotNull(prSingle.getUser().root);
46+
prSingle.getMergeable();
47+
assertNotNull(prSingle.getUser().root);
48+
49+
PagedIterable<GHPullRequest> ghPullRequests = getRepository().listPullRequests(GHIssueState.OPEN);
50+
for (GHPullRequest pr : ghPullRequests) {
51+
assertNotNull(pr.getUser().root);
52+
assertFalse(pr.getMergeable());
53+
assertNotNull(pr.getUser().root);
54+
}
55+
}
56+
4157
@After
4258
public void cleanUp() throws Exception {
4359
for (GHPullRequest pr : getRepository().getPullRequests(GHIssueState.OPEN)) {

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.