Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor: remove global lodash dependency #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

refactor: remove global lodash dependency #708

merged 1 commit into from
Oct 26, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Oct 25, 2022 •
edited by SumanthPuram
Loading

Description of the change

v1 changes related to #667

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs changed the title chore: remove global lodash refactor: remove global lodash dependency Oct 25, 2022
@MoumitaM MoumitaM merged commit 0438956 into v1-staging Oct 26, 2022
@MoumitaM MoumitaM deleted the chore/remove-global-lodash branch October 26, 2022 04:01
bardisg
bardisg reviewed Oct 26, 2022
View reviewed changes
package.json
"is": "^3.3.0",
"json3": "^3.3.3",
"lodash.clonedeep": "^4.5.0",
"lodash.get": "^4.4.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we do not just import lodash/xxx and treeshake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@utsabc utsabc Awaiting requested review from utsabc

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

+2 more reviewers

@bardisg bardisg bardisg left review comments

@shrouti1507 shrouti1507 shrouti1507 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MoumitaM @shrouti1507 @saikumarrs @bardisg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.