Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(dcm floodlight): add iframe support #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 28, 2022
Merged

feat(dcm floodlight): add iframe support #698

merged 10 commits into from
Oct 28, 2022

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Oct 20, 2022 •
edited
Loading

Description of the change

Add support to load DCM SDK using Iframe and refactored existing Gtag code.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@Gauravudia Gauravudia requested a review from akashrpo October 20, 2022 19:13
@Gauravudia Gauravudia self-assigned this Oct 20, 2022
MoumitaM
MoumitaM previously approved these changes Oct 25, 2022
View reviewed changes
utsabc
utsabc requested changes Oct 25, 2022
View reviewed changes
integrations/DCMFloodlight/browser.js Outdated Show resolved Hide resolved
integrations/DCMFloodlight/browser.js Outdated Show resolved Hide resolved
integrations/DCMFloodlight/utils.js Show resolved Hide resolved
integrations/DCMFloodlight/utils.js Show resolved Hide resolved
integrations/DCMFloodlight/utils.js Outdated Show resolved Hide resolved
shrouti1507
shrouti1507 reviewed Oct 25, 2022
View reviewed changes
integrations/DCMFloodlight/browser.js Outdated Show resolved Hide resolved
shrouti1507
shrouti1507 reviewed Oct 25, 2022
View reviewed changes
integrations/DCMFloodlight/browser.js Show resolved Hide resolved
akashrpo
akashrpo requested changes Oct 26, 2022
View reviewed changes
integrations/DCMFloodlight/browser.js Outdated Show resolved Hide resolved
integrations/DCMFloodlight/browser.js Outdated Show resolved Hide resolved
integrations/DCMFloodlight/browser.js Outdated Show resolved Hide resolved
integrations/DCMFloodlight/browser.js Show resolved Hide resolved
integrations/DCMFloodlight/browser.js Show resolved Hide resolved
@Gauravudia Gauravudia requested a review from MoumitaM October 28, 2022 06:19
akashrpo
akashrpo approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@akashrpo akashrpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gauravudia Gauravudia merged commit 4106c6e into v1-staging Oct 28, 2022
@Gauravudia Gauravudia deleted the feature/dcm_floodlight branch October 28, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utsabc utsabc utsabc approved these changes

@akashrpo akashrpo akashrpo approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

+2 more reviewers

@MoumitaM MoumitaM MoumitaM approved these changes

@shrouti1507 shrouti1507 shrouti1507 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Gauravudia Gauravudia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Gauravudia @utsabc @MoumitaM @shrouti1507 @akashrpo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.