Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(new-integration): onboarding yandex.metrica destination #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 17, 2022
Merged

feat(new-integration): onboarding yandex.metrica destination #671

merged 15 commits into from
Oct 17, 2022

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Sep 30, 2022 •
edited by SumanthPuram
Loading

Description of the change

onboarding yandex.metrica destination

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@ujjwal-ab ujjwal-ab self-assigned this Sep 30, 2022
@ujjwal-ab ujjwal-ab marked this pull request as draft September 30, 2022 05:48
@ujjwal-ab ujjwal-ab marked this pull request as ready for review September 30, 2022 16:07
MoumitaM
MoumitaM reviewed Oct 6, 2022
View reviewed changes
integrations/YandexMetrica/browser.js Show resolved Hide resolved
MoumitaM
MoumitaM reviewed Oct 6, 2022
View reviewed changes
integrations/YandexMetrica/browser.js Outdated Show resolved Hide resolved
integrations/YandexMetrica/browser.js Show resolved Hide resolved
ItsSudip
ItsSudip requested changes Oct 6, 2022
View reviewed changes
integrations/YandexMetrica/browser.js Show resolved Hide resolved
integrations/YandexMetrica/browser.js Show resolved Hide resolved
integrations/YandexMetrica/browser.js Show resolved Hide resolved
integrations/YandexMetrica/browser.js Outdated Show resolved Hide resolved
integrations/YandexMetrica/utils.js Outdated Show resolved Hide resolved
integrations/YandexMetrica/utils.js Outdated Show resolved Hide resolved
integrations/YandexMetrica/browser.js Outdated Show resolved Hide resolved
ItsSudip
ItsSudip reviewed Oct 7, 2022
View reviewed changes
integrations/YandexMetrica/utils.js Outdated Show resolved Hide resolved
ItsSudip
ItsSudip reviewed Oct 8, 2022
View reviewed changes
Copy link
Member

@ItsSudip ItsSudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments before the function definition.

integrations/YandexMetrica/browser.js Outdated Show resolved Hide resolved
@sauravlal-rudderstack
Copy link
Contributor

LGTM

MoumitaM
MoumitaM reviewed Oct 10, 2022
View reviewed changes
integrations/YandexMetrica/browser.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from ItsSudip October 10, 2022 14:53
MoumitaM
MoumitaM previously approved these changes Oct 10, 2022
View reviewed changes
MoumitaM
MoumitaM previously approved these changes Oct 11, 2022
View reviewed changes
@ujjwal-ab ujjwal-ab requested a review from MoumitaM October 12, 2022 16:24
@ujjwal-ab ujjwal-ab merged commit 5ceac7a into v1-staging Oct 17, 2022
@ujjwal-ab ujjwal-ab deleted the feature/YandexMetrica/destination branch October 17, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utsabc utsabc utsabc approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@sauravlal-rudderstack sauravlal-rudderstack Awaiting requested review from sauravlal-rudderstack

+1 more reviewer

@MoumitaM MoumitaM MoumitaM approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ujjwal-ab ujjwal-ab

Labels

new-integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ujjwal-ab @sauravlal-rudderstack @utsabc @MoumitaM @ItsSudip
Morty Proxy This is a proxified and sanitized view of the page, visit original site.