Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feature(ConvertFlow): Onboarding COnvertFlow for v1.1 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2022
Merged

feature(ConvertFlow): Onboarding COnvertFlow for v1.1 #619

merged 3 commits into from
Aug 24, 2022

Conversation

ujjwal-ab
Copy link
Contributor

@ujjwal-ab ujjwal-ab commented Aug 23, 2022 •
edited by SumanthPuram
Loading

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@ujjwal-ab ujjwal-ab added the Ready for review Changes are ready to be reviewed label Aug 23, 2022
@ujjwal-ab ujjwal-ab requested a review from ItsSudip August 23, 2022 08:56
@ujjwal-ab ujjwal-ab self-assigned this Aug 23, 2022
@ujjwal-ab ujjwal-ab requested a review from MoumitaM as a code owner August 23, 2022 08:56
MoumitaM
MoumitaM previously approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure config-be changes are released before the SDK release.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 37.08 KB (+0.21% 🔺) 742 ms (+0.21% 🔺) 120 ms (+20.73% 🔺) 861 ms
All Integrations - CDN 759.48 KB (+3.45% 🔺) 15.2 s (+3.45% 🔺) 856 ms (+2.31% 🔺) 16.1 s
Core - NPM 37.29 KB (+0.18% 🔺) 746 ms (+0.18% 🔺) 113 ms (+27.65% 🔺) 858 ms

utsabc
utsabc previously approved these changes Aug 23, 2022
View reviewed changes
@ujjwal-ab ujjwal-ab dismissed stale reviews from utsabc and MoumitaM via 14e4829 August 23, 2022 11:05
@ujjwal-ab ujjwal-ab requested review from MoumitaM and utsabc August 23, 2022 11:48
@saikumarrs saikumarrs merged commit 002c473 into production-staging Aug 24, 2022
@saikumarrs saikumarrs deleted the feature/ConvertFlow-v1.1 branch August 24, 2022 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@MoumitaM MoumitaM Awaiting requested review from MoumitaM

@utsabc utsabc Awaiting requested review from utsabc

Assignees

@ujjwal-ab ujjwal-ab

Labels

Ready for review Changes are ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ujjwal-ab @utsabc @MoumitaM @saikumarrs
Morty Proxy This is a proxified and sanitized view of the page, visit original site.