Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bugfix(non CFD): Matomo production PR #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

bugfix(non CFD): Matomo production PR #561

merged 2 commits into from
Jul 12, 2022

Conversation

rohithkaza
Copy link
Contributor

@rohithkaza rohithkaza commented Jul 12, 2022 •
edited
Loading

Description of the change

Matomo bugfix -production-staging branch

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@rohithkaza rohithkaza added Ready for review Changes are ready to be reviewed bug fix labels Jul 12, 2022
@rohithkaza rohithkaza requested review from ItsSudip and MoumitaM July 12, 2022 09:34
@rohithkaza rohithkaza self-assigned this Jul 12, 2022
@github-actions
Copy link

github-actions bot commented Jul 12, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 36.55 KB (0%) 732 ms (0%) 248 ms (+4% 🔺) 979 ms
All Integrations - CDN 663.44 KB (+0.06% 🔺) 13.3 s (+0.06% 🔺) 1.3 s (+4.78% 🔺) 14.6 s
Core - NPM 36.73 KB (0%) 735 ms (0%) 156 ms (-9.77% 🔽) 891 ms

@rohithkaza rohithkaza changed the base branch from production to production-staging July 12, 2022 09:50
@utsabc utsabc merged commit 68d6b11 into production-staging Jul 12, 2022
@utsabc utsabc deleted the bugfix/matomo-production branch July 12, 2022 11:58
@rohithkaza rohithkaza removed the Ready for review Changes are ready to be reviewed label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@utsabc utsabc utsabc approved these changes

@MoumitaM MoumitaM Awaiting requested review from MoumitaM

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@rohithkaza rohithkaza

Labels

bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohithkaza @utsabc
Morty Proxy This is a proxified and sanitized view of the page, visit original site.