Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c672d6e

Browse filesBrowse files
Earlopaineregon
authored andcommitted
Add a windows job to CI
1 parent 393ad72 commit c672d6e
Copy full SHA for c672d6e

File tree

3 files changed

+8
-3
lines changed
Filter options

3 files changed

+8
-3
lines changed

‎.github/workflows/ci.yml

Copy file name to clipboardExpand all lines: .github/workflows/ci.yml
+6-2Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,24 @@ concurrency:
66

77
jobs:
88
build:
9-
runs-on: ubuntu-latest
9+
runs-on: ${{ matrix.os }}-latest
1010
timeout-minutes: 10
1111

1212
strategy:
1313
fail-fast: false
1414
matrix:
1515
ruby: [2.3, 2.4, 2.5, 2.6, 2.7, '3.0', 3.1, 3.2, 3.3, jruby, truffleruby]
16+
os: [ubuntu]
17+
include:
18+
- ruby: 3.3
19+
os: windows
1620

1721
env:
1822
JAVA_OPTS: '-Xmx1024m'
1923
RUBYOPT: '-w'
2024
JRUBY_OPTS: '--dev'
2125

22-
name: "Tests: Ruby ${{ matrix.ruby }}"
26+
name: "Tests: Ruby ${{ matrix.ruby }} - ${{ matrix.os }}"
2327
steps:
2428
- name: Clone Repo
2529
uses: actions/checkout@v4

‎spec/concurrent/channel/integration_spec.rb

Copy file name to clipboardExpand all lines: spec/concurrent/channel/integration_spec.rb
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
end
6969

7070
specify 'default-selection.rb' do
71-
skip('flaky') if Concurrent.on_jruby? || Concurrent.on_truffleruby?
71+
skip('flaky') if Concurrent.on_jruby? || Concurrent.on_truffleruby? || Concurrent.on_windows?
7272
expected = <<-STDOUT
7373
.
7474
.

‎spec/concurrent/promises_spec.rb

Copy file name to clipboardExpand all lines: spec/concurrent/promises_spec.rb
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -758,6 +758,7 @@ def behaves_as_delay(delay, value)
758758
describe 'value!' do
759759
%w[with without].each do |timeout|
760760
it "does not return spuriously #{timeout} timeout" do
761+
skip "SIGHUP not supported" if Concurrent.on_windows?
761762
# https://github.com/ruby-concurrency/concurrent-ruby/issues/1015
762763
trapped = false
763764
original_handler = Signal.trap(:SIGHUP) { trapped = true }

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.