Fix a regression where MAKE on windows has an extra space at the end #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
eregon
reviewed
May 16, 2025
| @@ -138,7 +138,7 @@ async function installMSYS2(url, rubyPrefix = process.env.RUNNER_TEMP) { | ||
|
|
||
| const ridk = `${rubyPrefix}\\bin\\ridk.cmd` | ||
| if (fs.existsSync(ridk)) { | ||
| await common.measure('Setting up ridk environment', async () => exportCommandEnv(`set MAKE=make && "${ridk}" enable`)) | ||
| await common.measure('Setting up ridk environment', async () => exportCommandEnv(`set "MAKE=make" && "${ridk}" enable`)) |
There was a problem hiding this comment.
Weird, so it was parsed like set MAKE=make && "${ridk}" enable?
Or like set MAKE="make && ${ridk} enable"?
There was a problem hiding this comment.
CMD's quote and space parsing is really weird: https://superuser.com/questions/57723/prevent-extra-space-when-setting-variable-on-windows-command-line
eregon
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rubygems/rubygems#8700 (comment)
@eregon Can you please take a look?