Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e17c5ea

Browse filesBrowse files
headiuseregon
authored andcommitted
Handle exec error
Apparently this exec errors when the subprocess fails rather than returning an error code. This causes the whole setup process to terminate. This patch catches the error and uses that to indicate failure to launch.
1 parent f0a4d6b commit e17c5ea
Copy full SHA for e17c5ea

File tree

2 files changed

+2
-2
lines changed
Filter options

2 files changed

+2
-2
lines changed

‎common.js

Copy file name to clipboardExpand all lines: common.js
+1-1
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ export async function setupJavaHome() {
409409
await measure("Modifying JAVA_HOME for JRuby", async () => {
410410
console.log("attempting to run with existing JAVA_HOME")
411411

412-
let ret = await exec.exec('ruby', ['--version'])
412+
let ret = await exec.exec('ruby', ['--version'], {ignoreReturnCode: true})
413413

414414
if (ret === 0) {
415415
console.log("JRuby successfully starts, using existing JAVA_HOME")

‎dist/index.js

Copy file name to clipboardExpand all lines: dist/index.js
+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.