Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 60632a5

Browse filesBrowse files
vikiv480naitoh
andcommitted
Improve readability for #entity
* Early return if there is no `entities` * Early return if there is no match for `reference` in `entities` Co-Authored-By: NAITOH Jun <naitoh@gmail.com>
1 parent 6555c27 commit 60632a5
Copy full SHA for 60632a5

File tree

Expand file treeCollapse file tree

1 file changed

+6
-7
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-7
lines changed

‎lib/rexml/parsers/baseparser.rb

Copy file name to clipboardExpand all lines: lib/rexml/parsers/baseparser.rb
+6-7Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -505,14 +505,13 @@ def pull_event
505505
private :pull_event
506506

507507
def entity( reference, entities )
508-
value = nil
509-
value = entities[ reference ] if entities
510-
if value
511-
record_entity_expansion
512-
return unnormalize( value, entities )
513-
end
508+
return unless entities
509+
510+
value = entities[ reference ]
511+
return if value.nil?
514512

515-
nil
513+
record_entity_expansion
514+
unnormalize( value, entities )
516515
end
517516

518517
# Escapes all possible entities

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.