Cast divmod quotient to int #312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's green now, could I ask for a review? |
|
@mrzasa We should consider the timing of merging this change into the master branch due to the incompatibility introduced. It should be v3.4 or v3.5. Wait a moment, please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cast the quotient of
divmodto integer.It seems to be reasonable to make this change on the last step - just before returning to the caller, not inside
BigDecimal_DoDivmod.BigDecimal_DoDivmodis widely used in other places of the gem and changing its inteface would be cumbersome and risky.Rationale
FloatandIntegerreturn anIntegeras the first result of#divmod.Fixes #262
Blocked by #313