Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 623bf74

Browse filesBrowse files
ydahydah
committed
Remove test for safety configuration of cops documented with @safety YARD tag
This is because in some cases, even when a safety tag is present, `safe` may be `false` or `set_autocorrect` may be `true`. - https://github.com/rubocop/rubocop-rspec/blob/e63ee9a79c17be296d41ac36dc006d94d6d12069/lib/rubocop/cop/rspec/example_wording.rb#L13-L25
1 parent ef3f1ee commit 623bf74
Copy full SHA for 623bf74

File tree

Expand file treeCollapse file tree

1 file changed

+0
-14
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-14
lines changed
Open diff view settings
Collapse file

‎spec/project/default_config_spec.rb‎

Copy file name to clipboardExpand all lines: spec/project/default_config_spec.rb
-14Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -102,18 +102,4 @@ def cop_configuration(config_key)
102102
)
103103
end
104104
end
105-
106-
it 'is expected that all cops documented with `@safety` are `Safe: false` ' \
107-
'or `SafeAutoCorrect: false`' do
108-
unsafe_cop_names.each do |cop_name|
109-
unsafe = default_config[cop_name]['Safe'] == false ||
110-
default_config[cop_name]['SafeAutoCorrect'] == false
111-
expect(unsafe).to(
112-
be(true),
113-
"`#{cop_name}` cop should be set `Safe: false` or " \
114-
'`SafeAutoCorrect: false` because `@safety` YARD tag exists.'
115-
)
116-
YARD::Registry.clear
117-
end
118-
end
119105
end

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.