rtic-rs
diff --git a/‎src/accessors.rs
Copy file name to clipboardExpand all lines: src/accessors.rs
+1-4Lines changed: 1 addition & 4 deletions b/‎src/accessors.rs
Copy file name to clipboardExpand all lines: src/accessors.rs
+1-4Lines changed: 1 addition & 4 deletions
diff --git a/‎src/analyze.rs
Copy file name to clipboardExpand all lines: src/analyze.rs
+1-1Lines changed: 1 addition & 1 deletion b/‎src/analyze.rs
Copy file name to clipboardExpand all lines: src/analyze.rs
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/parse.rs
Copy file name to clipboardExpand all lines: src/parse.rs
+5-9Lines changed: 5 additions & 9 deletions b/‎src/parse.rs
Copy file name to clipboardExpand all lines: src/parse.rs
+5-9Lines changed: 5 additions & 9 deletions
diff --git a/‎src/parse/monotonic.rs
Copy file name to clipboardExpand all lines: src/parse/monotonic.rs
+1-1Lines changed: 1 addition & 1 deletion b/‎src/parse/monotonic.rs
Copy file name to clipboardExpand all lines: src/parse/monotonic.rs
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/parse/util.rs
Copy file name to clipboardExpand all lines: src/parse/util.rs
+6-8Lines changed: 6 additions & 8 deletions b/‎src/parse/util.rs
Copy file name to clipboardExpand all lines: src/parse/util.rs
+6-8Lines changed: 6 additions & 8 deletions
@@ -32,10 +32,7 @@ impl App {
     }
 
     fn is_external(task_local: &TaskLocal) -> bool {
-        match task_local {
-            TaskLocal::External => true,
-            _ => false,
-        }
+        matches!(task_local, TaskLocal::External)
     }
 
     pub(crate) fn local_resource_accesses(&self) -> impl Iterator<Item = &Ident> {
 
@@ -172,7 +172,7 @@ pub(crate) fn app(app: &App) -> Result<Analysis, syn::Error> {
 
     // Collect errors if any and return/halt
     if !error.is_empty() {
-        let mut err = error.iter().next().unwrap().clone();
+        let mut err = error.get(0).unwrap().clone();
         error.iter().for_each(|e| err.combine(e.clone()));
         return Err(err);
     }
 
@@ -107,20 +107,16 @@ fn init_args(tokens: TokenStream2) -> parse::Result<InitArgs> {
                 break;
             }
 
-            // ,
             let _: Token![,] = content.parse()?;
         }
 
         if let Some(locals) = &local_resources {
             for (ident, task_local) in locals {
-                match task_local {
-                    TaskLocal::External => {
-                        return Err(parse::Error::new(
-                            ident.span(),
-                            "only declared local resources are allowed in init",
-                        ));
-                    }
-                    _ => {}
+                if let TaskLocal::External = task_local {
+                    return Err(parse::Error::new(
+                        ident.span(),
+                        "only declared local resources are allowed in init",
+                    ));
                 }
             }
         }
 
@@ -25,7 +25,7 @@ impl Monotonic {
 
         let FilterAttrs { cfgs, attrs, .. } = util::filter_attributes(item.attrs.clone());
 
-        if attrs.len() > 0 {
+        if !attrs.is_empty() {
             return Err(parse::Error::new(
                 attrs[0].path.span(),
                 "Monotonic does not support attributes other than `#[cfg]`",
 
@@ -279,7 +279,7 @@ fn extract_init_resource_name_ident(ty: Type) -> Result<Ident, ()> {
     }
 }
 
-/// Checks Init's return type and returns the user provided types for use in the analysis
+/// Checks Init's return type, return the user provided types for analysis
 pub fn type_is_init_return(ty: &ReturnType, name: &str) -> Result<(Ident, Ident), ()> {
     match ty {
         ReturnType::Default => Err(()),
@@ -291,13 +291,11 @@ pub fn type_is_init_return(ty: &ReturnType, name: &str) -> Result<(Ident, Ident)
                 //
                 // We check the length and the last one here, analysis checks that the user
                 // provided structs are correct.
-                if t.elems.len() == 3 {
-                    if type_is_path(&t.elems[2], &[name, "Monotonics"]) {
-                        return Ok((
-                            extract_init_resource_name_ident(t.elems[0].clone())?,
-                            extract_init_resource_name_ident(t.elems[1].clone())?,
-                        ));
-                    }
+                if t.elems.len() == 3 && type_is_path(&t.elems[2], &[name, "Monotonics"]) {
+                    return Ok((
+                        extract_init_resource_name_ident(t.elems[0].clone())?,
+                        extract_init_resource_name_ident(t.elems[1].clone())?,
+                    ));
                 }
 
                 Err(())
Original file line number	Diff line number	Diff line change
`@@ -32,10 +32,7 @@ impl App {`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`fn is_external(task_local: &TaskLocal) -> bool {`
`35`		`- match task_local {`
`36`		`- TaskLocal::External => true,`
`37`		`- _ => false,`
`38`		`- }`
	`35`	`+ matches!(task_local, TaskLocal::External)`
`39`	`36`	`}`
`40`	`37`
`41`	`38`	`pub(crate) fn local_resource_accesses(&self) -> impl Iterator<Item = &Ident> {`
Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ pub(crate) fn app(app: &App) -> Result<Analysis, syn::Error> {`
`172`	`172`
`173`	`173`	`// Collect errors if any and return/halt`
`174`	`174`	`if !error.is_empty() {`
`175`		`- let mut err = error.iter().next().unwrap().clone();`
	`175`	`+ let mut err = error.get(0).unwrap().clone();`
`176`	`176`	`error.iter().for_each(\|e\| err.combine(e.clone()));`
`177`	`177`	`return Err(err);`
`178`	`178`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,20 +107,16 @@ fn init_args(tokens: TokenStream2) -> parse::Result<InitArgs> {`
`107`	`107`	`break;`
`108`	`108`	`}`
`109`	`109`
`110`		`- // ,`
`111`	`110`	`let _: Token![,] = content.parse()?;`
`112`	`111`	`}`
`113`	`112`
`114`	`113`	`if let Some(locals) = &local_resources {`
`115`	`114`	`for (ident, task_local) in locals {`
`116`		`- match task_local {`
`117`		`- TaskLocal::External => {`
`118`		`- return Err(parse::Error::new(`
`119`		`- ident.span(),`
`120`		`- "only declared local resources are allowed in init",`
`121`		`- ));`
`122`		`- }`
`123`		`- _ => {}`
	`115`	`+ if let TaskLocal::External = task_local {`
	`116`	`+ return Err(parse::Error::new(`
	`117`	`+ ident.span(),`
	`118`	`+ "only declared local resources are allowed in init",`
	`119`	`+ ));`
`124`	`120`	`}`
`125`	`121`	`}`
`126`	`122`	`}`