Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore: remove babel-plugin-lodash #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: next
Choose a base branch
Loading
from
Open

chore: remove babel-plugin-lodash #4107

wants to merge 3 commits into from

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented Jan 3, 2025

This pull request focuses on removing the lodash library and its related plugins from the project, as well as updating import statements to use specific lodash functions. Additionally, it includes a minor change to an ESLint directive in the webpack.config.js file.

Removal of lodash and related plugins:

  • babel.config.js: Removed the 'lodash' plugin from the Babel plugins list.
  • package.json: Removed babel-plugin-lodash and lodash-webpack-plugin from the dependencies. [1] [2]
  • webpack.config.js: Removed LodashModuleReplacementPlugin and its configuration.

Update of lodash import statements:

ESLint directive update:

  • webpack.config.js: Updated ESLint directive to use @typescript-eslint/no-require-imports instead of @typescript-eslint/no-var-requires.

Copy link

codesandbox bot commented Jan 3, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 9:10am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 9:10am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 9:10am

Copy link

codesandbox-ci bot commented Jan 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (cf160fe) to head (e6a2e58).

Files with missing lines Patch % Lines
src/MaskedInput/test/adjustCaretPositionSpec.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next    #4107   +/-   ##
=======================================
  Coverage   89.51%   89.51%           
=======================================
  Files         520      520           
  Lines       12381    12381           
  Branches     3180     3180           
=======================================
  Hits        11083    11083           
  Misses        635      635           
  Partials      663      663           
Flag Coverage Δ
ChromeCi 75.44% <91.66%> (ø)
Firefox 89.49% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.