refactor: deprecated React 17 #4078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4078 +/- ##
==========================================
- Coverage 89.29% 89.24% -0.05%
==========================================
Files 517 517
Lines 12220 12186 -34
Branches 3169 3162 -7
==========================================
- Hits 10912 10876 -36
- Misses 644 646 +2
Partials 664 664
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the testing setup and dependencies for the project, focusing on updating React versions and improving the testing library usage. The most important changes include removing support for React 17, updating peer dependencies, and refactoring test imports and assertions.
React version updates:
package.json, and updated peer dependencies to require React 18 or higher. (.github/workflows/nodejs-ci.yml,package.json) [1] [2] [3] [4]Testing library updates:
@testing-library/reactdirectly instead of custom utilities, and updated assertions to usescreenandexpect. (src/Calendar/test/useCalendarDateSpec.tsx,src/Content/test/ContentStylesSpec.tsx,src/Modal/test/ModalSpec.tsx,src/internals/Plaintext/test/PlaintextSpec.tsx,src/internals/Ripple/test/RippleSpec.tsx) [1] [2] [3] [4] [5]Miscellaneous improvements:
aria-controlsandaria-describedbyattributes inPickerToggleto handle cases whereidis undefined. (src/internals/Picker/PickerToggle.tsx)useUniqueIdhook to use the built-inuseIdfrom React. (src/internals/hooks/useUniqueId.ts)