Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Adding full as a valid parameter for the size arg in modalD… #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from
Open

Adding full as a valid parameter for the size arg in modalD… #4298

wants to merge 1 commit into from
+13 −9

Conversation

federiva
Copy link

@federiva federiva commented Oct 7, 2025 •
edited
Loading

Closes #4297
Hey! thank you for this awesome package. Adding a small feature for modals here.

How to test

library(shiny)
library(bslib)

shinyApp(
  ui = bslib::page_fillable(
    actionButton("open", "open modal")
  ),
  server = function(input, output, session) {
    observe(
      showModal(
        modalDialog("fullscreen!", size = "full")
      )
    ) |> 
      bindEvent(input$open)
  }
)

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

gadenbuie
gadenbuie reviewed Oct 7, 2025
View reviewed changes
R/modal.R
#' @export
modalDialog <- function(..., title = NULL, footer = modalButton("Dismiss"),
size = c("m", "s", "l", "xl"), easyClose = FALSE, fade = TRUE) {
size = c("m", "s", "l", "xl", "full"), easyClose = FALSE, fade = TRUE) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fullscreen modal sizes have a few flavors

Class Availability
.modal-fullscreen Always
.modal-fullscreen-sm-down 576px
.modal-fullscreen-md-down 768px
.modal-fullscreen-lg-down 992px
.modal-fullscreen-xl-down 1200px
.modal-fullscreen-xxl-down 1400px

I like that modalDialog() helps you find the appropriate value, but more and more I feel like throwing an error for invalid value unnecessarily breaks future-compatibility with changing sizes.

I think the behavior I'd prefer here in this case is:

  1. If size is a known alias value, map to a specific class, e.g. "s" → modal-sm or "full" → modal-fullscreen.
  2. If size doesn't already have the modal- prefix, prepend it, e.g. "sm" → modal-sm or "fullscreen-lg-down" → modal-fullscreen-lg-down

I'm going to bring this up internally to see what the rest of the Shiny team thinks before we move forward.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primarily to support Bootstrap size aliases (they use sm, md, lg, etc. instead of the s, m, l used here in size). If they know about the full class and use modal-fullscreen-lg-down we wouldn't prepend modal- to the class.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadenbuie gadenbuie gadenbuie left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow fullscreen modal as a valid size for modalDialog when using Bootstrap 5

3 participants

@federiva @CLAassistant @gadenbuie
Morty Proxy This is a proxified and sanitized view of the page, visit original site.