Issue #484 fix #4254
Open
Issue #484 fix #4254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cpsievert
reviewed
Jul 14, 2025
| if (date instanceof Date) { | ||
| return ( | ||
| date.getUTCFullYear() + | ||
| date.getUTCFullYear().toString().padStart(4, "0") + |
There was a problem hiding this comment.
For consistency with the lines below
Suggested change
| date.getUTCFullYear().toString().padStart(4, "0") + | |
| padZeros(date.getUTCFullYear(), 4) + |
|
hi @ognevushka! great meeting you at the scipy sprints a few weeks ago. can you add me as a collaborator to your fork? i can work on getting the fixes done on our end so when we squash merge this PR you still get the credit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes posit-dev/py-shiny#484