Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b983304

Browse filesBrowse files
fnlctrlyyx990803
authored andcommitted
fix: avoid bailout of webpack module concatenation (vuejs#1230)
Webpack's module concatenation support was broken by v15 due to this `module.exports` line. Changing to ESM export fixes this issue.
1 parent 06e5d70 commit b983304
Copy full SHA for b983304

File tree

Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-3
lines changed

‎lib/loaders/pitcher.js

Copy file name to clipboardExpand all lines: lib/loaders/pitcher.js
+2-3Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ module.exports.pitch = function (remainingRequest) {
3737
...beforeLoaders
3838
])
3939
// console.log(request)
40-
// use cjs to ensure exports from (vue-)style-loader/css-loader are intact
41-
return `module.exports = require(${request})`
40+
return `import mod from ${request}; export default mod; export * from ${request}`
4241
}
4342
}
4443

@@ -66,5 +65,5 @@ module.exports.pitch = function (remainingRequest) {
6665
// both that rule and the cloned rule will match, resulting in duplicated
6766
// loaders. Therefore it is necessary to perform a dedupe here.
6867
const request = genRequest(loaders.map(toLoaderString))
69-
return `module.exports = require(${request})`
68+
return `import mod from ${request}; export default mod; export * from ${request}`
7069
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.