Add capnp & flatbuffers serialization support#948
Closed
linux-china wants to merge 1 commit intorsocket:masterrsocket/rsocket-java:masterfrom
Closed
Add capnp & flatbuffers serialization support#948linux-china wants to merge 1 commit intorsocket:masterrsocket/rsocket-java:masterfrom
linux-china wants to merge 1 commit intorsocket:masterrsocket/rsocket-java:masterfrom
Conversation
Cap’n Proto and FlatBuffers are high performance serialization library, and they should be included in WellKnownType, and especially useful to per stream DataMimeType, and text MimeType is too long for them because of performance. Signed-off-by: linux_china <libing.chen@gmail.com>
OlegDokuka
requested changes
Oct 25, 2020
Member
OlegDokuka
left a comment
There was a problem hiding this comment.
I guess this should be added first into the spec, and then into the certain implementation.
https://github.com/rsocket/rsocket/blob/master/Extensions/WellKnownMimeTypes.md
Member
|
Can we merge this now? https://github.com/rsocket/rsocket/commits/master/Extensions/WellKnownMimeTypes.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cap’n Proto and FlatBuffers are high performance serialization library, and they should be included in WellKnownType, and especially useful to per stream DataMimeType, and text MimeType is too long for them because of performance.