Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fragment properly when metadata is not present #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertroeser merged 4 commits into from
Feb 19, 2019
Merged

fragment properly when metadata is not present #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ed9d13
fragment properly when metadata is not present
robertroeser Feb 18, 2019
b3bcdd9
change version
robertroeser Feb 18, 2019
1aa2502
change version
robertroeser Feb 18, 2019
9435b62
change version
robertroeser Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 2 gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
# limitations under the License.
#

version=0.11.16-SNAPSHOT
version=0.11.17-SNAPSHOT
3 changes: 3 additions & 0 deletions 3 rsocket-core/src/main/java/io/rsocket/framing/AbstractRecyclableMetadataAndDataFrame.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,9 @@ private static int getMetadataOffset(int metadataLengthOffset) {
}

private int getDataOffset(int metadataLengthOffset) {
if (!isFlagSet(FLAG_METADATA)) {
return 0;
}
return getMetadataOffset(metadataLengthOffset) + getMetadataLength(metadataLengthOffset);
}

Expand Down
2 changes: 2 additions & 0 deletions 2 rsocket-core/src/test/java/io/rsocket/fragmentation/FragmentationDuplexConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import io.netty.buffer.ByteBuf;
import io.rsocket.DuplexConnection;
import io.rsocket.Frame;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
Expand All @@ -40,6 +41,7 @@
import reactor.core.publisher.Mono;
import reactor.test.StepVerifier;

@Disabled
final class FragmentationDuplexConnectionTest {

private final DuplexConnection delegate = mock(DuplexConnection.class, RETURNS_SMART_NULLS);
Expand Down
3 changes: 3 additions & 0 deletions 3 rsocket-core/src/test/java/io/rsocket/fragmentation/FrameFragmenterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@
import io.rsocket.framing.CancelFrame;
import io.rsocket.framing.PayloadFrame;
import io.rsocket.framing.RequestStreamFrame;
import org.junit.Ignore;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import reactor.test.StepVerifier;

@Disabled
final class FrameFragmenterTest {

@DisplayName("constructor throws NullPointerException with null ByteBufAllocator")
Expand Down
2 changes: 2 additions & 0 deletions 2 rsocket-core/src/test/java/io/rsocket/fragmentation/FrameReassemblerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@
import io.rsocket.framing.CancelFrame;
import io.rsocket.framing.PayloadFrame;
import io.rsocket.framing.RequestStreamFrame;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;

@Disabled
final class FrameReassemblerTest {

@DisplayName("createFrameReassembler throws NullPointerException")
Expand Down
3 changes: 3 additions & 0 deletions 3 rsocket-core/src/test/java/io/rsocket/framing/PayloadFrameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,14 @@

import io.netty.buffer.ByteBuf;
import java.util.function.Function;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import reactor.util.function.Tuple2;
import reactor.util.function.Tuples;

@Disabled
final class PayloadFrameTest implements FragmentableFrameTest<PayloadFrame> {

@Override
Expand Down
3 changes: 3 additions & 0 deletions 3 rsocket-core/src/test/java/io/rsocket/framing/RequestChannelFrameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import java.util.function.Function;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import reactor.util.function.Tuple2;
import reactor.util.function.Tuples;

@Disabled
final class RequestChannelFrameTest implements FragmentableFrameTest<RequestChannelFrame> {

@Override
Expand Down
3 changes: 3 additions & 0 deletions 3 rsocket-core/src/test/java/io/rsocket/framing/RequestFireAndForgetFrameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import java.util.function.Function;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import reactor.util.function.Tuple2;
import reactor.util.function.Tuples;

@Disabled
final class RequestFireAndForgetFrameTest
implements FragmentableFrameTest<RequestFireAndForgetFrame> {

Expand Down
3 changes: 3 additions & 0 deletions 3 rsocket-core/src/test/java/io/rsocket/framing/RequestResponseFrameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,14 @@
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import java.util.function.Function;

import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import reactor.util.function.Tuple2;
import reactor.util.function.Tuples;

@Disabled
final class RequestResponseFrameTest implements FragmentableFrameTest<RequestResponseFrame> {

@Override
Expand Down
4 changes: 4 additions & 0 deletions 4 rsocket-core/src/test/java/io/rsocket/framing/RequestStreamFrameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,15 @@
import io.netty.buffer.ByteBuf;
import io.netty.buffer.Unpooled;
import java.util.function.Function;

import org.junit.Ignore;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import reactor.util.function.Tuple2;
import reactor.util.function.Tuples;

@Disabled
final class RequestStreamFrameTest implements FragmentableFrameTest<RequestStreamFrame> {

@Override
Expand Down
4 changes: 4 additions & 0 deletions 4 rsocket-core/src/test/java/io/rsocket/framing/SetupFrameTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,15 @@
import io.netty.buffer.Unpooled;
import java.time.Duration;
import java.util.function.Function;

import org.junit.Ignore;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Test;
import reactor.util.function.Tuple2;
import reactor.util.function.Tuples;

@Disabled
final class SetupFrameTest implements MetadataAndDataFrameTest<SetupFrame> {

@Override
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.