Replace for loops with forEach in RSocketClient/Server to fix non-deterministic behavior#556
Merged
robertroeser merged 1 commit intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom Dec 12, 2018
Merged
Replace for loops with forEach in RSocketClient/Server to fix non-deterministic behavior#556robertroeser merged 1 commit intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom
robertroeser merged 1 commit intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom
Conversation
…erministic behavior Signed-off-by: Ryland Degnan <ryland@netifi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered a null pointer exception inside RSocketClient::cleanUpSubscriber because subscriber was null. The only way this could happen is if the receivers map is modified while it is being iterated over. The solution is to use the forEach method instead of iterator, which is properly synchronized.