Maven Dependency Improvements#502
Merged
rdegnan merged 1 commit intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom May 11, 2018
nebhale:498-maven-dependenciesCopy head branch name to clipboard
Merged
Maven Dependency Improvements#502rdegnan merged 1 commit intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom nebhale:498-maven-dependenciesCopy head branch name to clipboard
rdegnan merged 1 commit intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom
nebhale:498-maven-dependenciesCopy head branch name to clipboard
Conversation
Previously, an update the build system resulted in the Maven dependencies being aggressively calculated, before each project add dependencies to itself. This change updates the ordering of this calculation such that it happens after each project configures itself. In addition, this change goes through each project and ensures that the dependencies are scoped appropriately in order to achieve the a minimal and accurate Maven POM. [#463][#498]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, an update the build system resulted in the Maven dependencies being aggressively calculated, before each project add dependencies to itself. This change updates the ordering of this calculation such that it happens after each project configures itself. In addition, this change goes through each project and ensures that the dependencies are scoped appropriately in order to achieve the a minimal and accurate Maven POM.
Sample of the generated POMs