RSocket hanging on large channels#438
Merged
robertroeser merged 3 commits intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom Oct 30, 2017
Merged
RSocket hanging on large channels#438robertroeser merged 3 commits intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom
robertroeser merged 3 commits intorsocket:1.0.xrsocket/rsocket-java:1.0.xfrom
Conversation
…ng with large number of items
yschimke
approved these changes
Oct 30, 2017
Member
yschimke
left a comment
There was a problem hiding this comment.
The UnboundedProcessor is a tough read, is that from scratch?
| } | ||
|
|
||
| @Test(timeout = 10000) | ||
| @Test//(timeout = 10000) |
Member
Author
There was a problem hiding this comment.
Yeah I'll add the timeouts back
Member
|
Does this resolve rsocket/rsocket#241 |
Member
Author
|
@yschimke yes it fixes that Also I did not write the processor from scratch - its based on Reactor-core's UnicastProcessor. |
yschimke
approved these changes
Oct 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When streaming data from a channel RSocket would hang. Replaced the processors in the RSocketClient and RSocketServer with ones that can emit when the onNext method is called to prevent a live lock. Basically a Unicast processor with the operator fusion code removed, and a thread-safe queue. Also fixes a bug when an channel receiving an empty publisher wouldn't complete.