Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Make RequestHandler an interface #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdegnan merged 1 commit into from
Jul 22, 2016
Merged

Make RequestHandler an interface #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions 28 reactivesocket-core/src/main/java/io/reactivesocket/RequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,42 +18,42 @@

import java.util.function.Function;

public abstract class RequestHandler {
private static final Function<Payload, Publisher<Payload>> NO_REQUEST_RESPONSE_HANDLER =
public interface RequestHandler {
Function<Payload, Publisher<Payload>> NO_REQUEST_RESPONSE_HANDLER =
payload -> PublisherUtils.errorPayload(new RuntimeException("No 'requestResponse' handler"));

private static final Function<Payload, Publisher<Payload>> NO_REQUEST_STREAM_HANDLER =
Function<Payload, Publisher<Payload>> NO_REQUEST_STREAM_HANDLER =
payload -> PublisherUtils.errorPayload(new RuntimeException("No 'requestStream' handler"));

private static final Function<Payload, Publisher<Payload>> NO_REQUEST_SUBSCRIPTION_HANDLER =
Function<Payload, Publisher<Payload>> NO_REQUEST_SUBSCRIPTION_HANDLER =
payload -> PublisherUtils.errorPayload(new RuntimeException("No 'requestSubscription' handler"));

private static final Function<Payload, Publisher<Void>> NO_FIRE_AND_FORGET_HANDLER =
Function<Payload, Publisher<Void>> NO_FIRE_AND_FORGET_HANDLER =
payload -> Publishers.error(new RuntimeException("No 'fireAndForget' handler"));

private static final Function<Publisher<Payload>, Publisher<Payload>> NO_REQUEST_CHANNEL_HANDLER =
Function<Publisher<Payload>, Publisher<Payload>> NO_REQUEST_CHANNEL_HANDLER =
payloads -> PublisherUtils.errorPayload(new RuntimeException("No 'requestChannel' handler"));

private static final Function<Payload, Publisher<Void>> NO_METADATA_PUSH_HANDLER =
Function<Payload, Publisher<Void>> NO_METADATA_PUSH_HANDLER =
payload -> Publishers.error(new RuntimeException("No 'metadataPush' handler"));

public abstract Publisher<Payload> handleRequestResponse(final Payload payload);
Publisher<Payload> handleRequestResponse(final Payload payload);

public abstract Publisher<Payload> handleRequestStream(final Payload payload);
Publisher<Payload> handleRequestStream(final Payload payload);

public abstract Publisher<Payload> handleSubscription(final Payload payload);
Publisher<Payload> handleSubscription(final Payload payload);

public abstract Publisher<Void> handleFireAndForget(final Payload payload);
Publisher<Void> handleFireAndForget(final Payload payload);

/**
* @note The initialPayload will also be part of the inputs publisher.
* It is there to simplify routing logic.
*/
public abstract Publisher<Payload> handleChannel(Payload initialPayload, final Publisher<Payload> inputs);
Publisher<Payload> handleChannel(final Payload initialPayload, final Publisher<Payload> inputs);

public abstract Publisher<Void> handleMetadataPush(final Payload payload);
Publisher<Void> handleMetadataPush(final Payload payload);

public static class Builder {
class Builder {
private Function<Payload, Publisher<Payload>> handleRequestResponse = NO_REQUEST_RESPONSE_HANDLER;
private Function<Payload, Publisher<Payload>> handleRequestStream = NO_REQUEST_STREAM_HANDLER;
private Function<Payload, Publisher<Payload>> handleRequestSubscription = NO_REQUEST_SUBSCRIPTION_HANDLER;
Expand Down
2 changes: 1 addition & 1 deletion 2 reactivesocket-test/src/main/java/io/reactivesocket/test/TestRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

import static rx.RxReactiveStreams.*;

public class TestRequestHandler extends RequestHandler {
public class TestRequestHandler implements RequestHandler {

@Override
public Publisher<Payload> handleRequestResponse(Payload payload) {
Expand Down
1 change: 0 additions & 1 deletion 1 reactivesocket-transport-local/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
*/

dependencies {
compile project(':reactivesocket-transport-tcp')
compile project(':reactivesocket-core')

testCompile project(':reactivesocket-test')
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.