Disable Backup-Request / Retries.#102
Merged
NiteshKant merged 2 commits intomasterrsocket/rsocket-java:masterfrom Jun 23, 2016
stevegury/disable-backup-requestrsocket/rsocket-java:stevegury/disable-backup-requestCopy head branch name to clipboard
Merged
Disable Backup-Request / Retries.#102NiteshKant merged 2 commits intomasterrsocket/rsocket-java:masterfrom stevegury/disable-backup-requestrsocket/rsocket-java:stevegury/disable-backup-requestCopy head branch name to clipboard
NiteshKant merged 2 commits intomasterrsocket/rsocket-java:masterfrom
stevegury/disable-backup-requestrsocket/rsocket-java:stevegury/disable-backup-requestCopy head branch name to clipboard
Conversation
**Problem** There are bugs related to Backup-Request/Retries subscription. The remaining part of the code is ok. **Solution** Disable the code in the ClientBuilder.
| connector, | ||
| source | ||
| ); | ||
| throw new IllegalArgumentException("BackupRequest is experimental/disabled."); |
Contributor
There was a problem hiding this comment.
Do you want to remove these methods for now?
We are anyways breaking API backward compatibility with the RxNetty chane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are bugs related to Backup-Request/Retries subscription.
The remaining part of the code is ok.
Solution
Disable the code in the ClientBuilder.