Allowing parse to work with missing __doc__#103
Merged
mauvilsa merged 2 commits intorr-:masterrr-/docstring_parser:masterfrom Jul 25, 2025
jamesbraza:optional-strCopy head branch name to clipboard
Merged
Allowing parse to work with missing __doc__#103mauvilsa merged 2 commits intorr-:masterrr-/docstring_parser:masterfrom jamesbraza:optional-strCopy head branch name to clipboard
parse to work with missing __doc__#103mauvilsa merged 2 commits intorr-:masterrr-/docstring_parser:masterfrom
jamesbraza:optional-strCopy head branch name to clipboard
Conversation
mauvilsa
requested changes
Jul 25, 2025
Collaborator
mauvilsa
left a comment
There was a problem hiding this comment.
docstring-parser is currently supported in python 3.8 and 3.9, where the syntax | None is invalid. So the changes can't be like this, but using Optional[] instead.
Contributor
Author
Ah I see, just pushed a change to |
mauvilsa
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rr-/docstring_parser/issues/88