Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 77c3851

Browse filesBrowse files
committed
commit icon near to 'commits' field
1 parent 0c25c31 commit 77c3851
Copy full SHA for 77c3851

File tree

Expand file treeCollapse file tree

2 files changed

+13
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+13
-1
lines changed
Open diff view settings
Collapse file

‎app/res/layout/issue_header.xml‎

Copy file name to clipboardExpand all lines: app/res/layout/issue_header.xml
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,19 @@
7171
android:layout_marginLeft="10dp"
7272
android:layout_marginRight="10dp"
7373
android:background="@drawable/inset_background"
74-
android:orientation="vertical"
74+
android:orientation="horizontal"
7575
android:visibility="gone" >
7676

77+
<TextView
78+
android:id="@+id/tv_commit_icon"
79+
style="@style/PrimaryIcon"
80+
android:paddingRight="5dp" />
81+
7782
<TextView
7883
android:id="@+id/tv_pull_request_commits"
7984
style="@style/ListTitleText"
8085
android:paddingBottom="0dp"
86+
android:layout_gravity="center_vertical"
8187
android:singleLine="true" />
8288

8389
</LinearLayout>
Collapse file

‎app/src/main/java/com/github/mobile/ui/issue/IssueFragment.java‎

Copy file name to clipboardExpand all lines: app/src/main/java/com/github/mobile/ui/issue/IssueFragment.java
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import static com.github.mobile.RequestCodes.ISSUE_MILESTONE_UPDATE;
3333
import static com.github.mobile.RequestCodes.ISSUE_REOPEN;
3434
import static org.eclipse.egit.github.core.service.IssueService.STATE_OPEN;
35+
import static com.github.mobile.util.TypefaceUtils.ICON_COMMIT;
3536
import android.app.Activity;
3637
import android.content.Intent;
3738
import android.os.Bundle;
@@ -70,6 +71,7 @@
7071
import com.github.mobile.util.HttpImageGetter;
7172
import com.github.mobile.util.ShareUtils;
7273
import com.github.mobile.util.ToastUtils;
74+
import com.github.mobile.util.TypefaceUtils;
7375
import com.google.inject.Inject;
7476

7577
import java.util.ArrayList;
@@ -354,6 +356,10 @@ private void updateHeader(final Issue issue) {
354356
if (IssueUtils.isPullRequest(issue) && issue.getPullRequest().getCommits() > 0) {
355357
ViewUtils.setGone(commitsView, false);
356358

359+
TextView icon = (TextView) commitsView.findViewById(id.tv_commit_icon);
360+
TypefaceUtils.setOcticons(icon);
361+
icon.setText(ICON_COMMIT);
362+
357363
String commits = getString(string.pull_request_commits,
358364
issue.getPullRequest().getCommits());
359365
((TextView) commitsView.findViewById(id.tv_pull_request_commits)).setText(commits);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.