Best #463
Merged
Best #463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the default value of the "best" option changed to True, this test fails. The following bug was filed: https://bugzilla.redhat.com/show_bug.cgi?id=1672618
|
Thanks, nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I made some tests for the new behavior with the "best" option, as requested by these bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1670776
https://bugzilla.redhat.com/show_bug.cgi?id=1671683
The tests fail without the following PRs:
rpm-software-management/dnf#1311
rpm-software-management/libdnf#678
I also needed to change few of the current tests to reflect the change.
I am not sure about the tags, though. I referenced both bugs in all the scenarios that require the changed behavior, but if I should do this differently just let me know.
In addition, the test in obsoletes-keep-reason.feature now found following bug: https://bugzilla.redhat.com/show_bug.cgi?id=1672618